git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] commit: document that $command.signoff will not be added

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 17, 2025, 23:16 UTC
Message-ID
<xmqq7buk1yxm.fsf@gitster.g>
In-Reply-To
<7bde8cd7-7487-4270-98e5-ab598b0a91d1@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 6 quoted lines
>> +There exists `format.signoff`, but that is a historical mistake, and
>> +it is not an excuse to pile on more mistakes of the same kind on top.
>
> I feel that we should s/pile on/pile/, but I am not a native speaker.
>
> This patch looks good with or without this change.

Thanks. "add more mistakes" should be clear for everybody, so I'll change the verb.

Previous: Johannes SixtNext: Kristoffer Haugsbakk
Message 18 of 20 in “Would it make sense to add a commit.signOff config?”
  1. Stefan HallerDec 14, 2025
  2. Carlo Marcelo Arenas BelónDec 14, 2025
  3. Junio C HamanoDec 14, 2025
  4. Collin FunkDec 14, 2025
  5. brian m. carlsonDec 15, 2025
  6. Junio C HamanoDec 15, 2025
  7. brian m. carlsonDec 15, 2025
  8. Junio C HamanoDec 16, 2025
  9. Elijah NewrenDec 16, 2025
  10. Junio C HamanoDec 16, 2025
  11. Johannes SixtDec 16, 2025
  12. Johannes SixtDec 16, 2025
  13. commit: document that $command.signoff will not be addedJunio C Hamano, Dec 16, 2025
  14. Elijah NewrenDec 16, 2025
  15. Junio C HamanoDec 17, 2025
  16. Elijah NewrenDec 17, 2025
  17. Johannes SixtDec 17, 2025
  18. Junio C HamanoDec 17, 2025
  19. Kristoffer HaugsbakkDec 19, 2025
  20. Junio C HamanoDec 19, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.