Re: Would it make sense to add a commit.signOff config?
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- Dec 14, 2025, 16:44 UTC
- Message-ID
- <aT7lkXl65-TBIsRS@Carlos-MacBook-Air.local>
- In-Reply-To
- <86c5d40d-5a06-4a69-90d8-a737685b0536@haller-berlin.de>
On Sun, Dec 14, 2025 at 05:10:19PM -0800, Stefan Haller wrote:
Show 16 quoted lines
> I find it interesting that of all the git commands that take a --signoff > argument, format-patch is the only one that has a corresponding config > to turn it on for all invocations. I would have thought that git commit > needs this even more; I find it reasonable for users to decide that they > want to add a Signed-off-by trailer to all the commits they make. > > But then, what about merge, cherry-pick, and revert? Does it make sense > to turn it on globally for those as well? > > The background of this question is lazygit, which has a config for > enabling --signoff for all commits made by it. We recently had a feature > request to extend the meaning of that config to revert as well, and the > discussion came up whether that's a good idea, and if so, whether it > should also extend to cherry-pick and merge. > > Any opinions about this?
this was discussed recently[0] and the point that was made is that SOA are meant to be relevant mainly in open source contexts and should be explicitly given.
Carlo
[0] https://lore.kernel.org/git/xmqq4iwvfx8s.fsf@gitster.g/