git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Would it make sense to add a commit.signOff config?

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Dec 14, 2025, 16:44 UTC
Message-ID
<aT7lkXl65-TBIsRS@Carlos-MacBook-Air.local>
In-Reply-To
<86c5d40d-5a06-4a69-90d8-a737685b0536@haller-berlin.de>
On Sun, Dec 14, 2025 at 05:10:19PM -0800, Stefan Haller wrote:
Show 16 quoted lines
> I find it interesting that of all the git commands that take a --signoff
> argument, format-patch is the only one that has a corresponding config
> to turn it on for all invocations. I would have thought that git commit
> needs this even more; I find it reasonable for users to decide that they
> want to add a Signed-off-by trailer to all the commits they make.
> 
> But then, what about merge, cherry-pick, and revert? Does it make sense
> to turn it on globally for those as well?
> 
> The background of this question is lazygit, which has a config for
> enabling --signoff for all commits made by it. We recently had a feature
> request to extend the meaning of that config to revert as well, and the
> discussion came up whether that's a good idea, and if so, whether it
> should also extend to cherry-pick and merge.
> 
> Any opinions about this?

this was discussed recently[0] and the point that was made is that SOA are meant to be relevant mainly in open source contexts and should be explicitly given.

Carlo
[0] https://lore.kernel.org/git/xmqq4iwvfx8s.fsf@gitster.g/
Previous: Stefan HallerNext: Junio C Hamano
Message 2 of 20 in “Would it make sense to add a commit.signOff config?”
  1. Stefan HallerDec 14, 2025
  2. Carlo Marcelo Arenas BelónDec 14, 2025
  3. Junio C HamanoDec 14, 2025
  4. Collin FunkDec 14, 2025
  5. brian m. carlsonDec 15, 2025
  6. Junio C HamanoDec 15, 2025
  7. brian m. carlsonDec 15, 2025
  8. Junio C HamanoDec 16, 2025
  9. Elijah NewrenDec 16, 2025
  10. Junio C HamanoDec 16, 2025
  11. Johannes SixtDec 16, 2025
  12. Johannes SixtDec 16, 2025
  13. commit: document that $command.signoff will not be addedJunio C Hamano, Dec 16, 2025
  14. Elijah NewrenDec 16, 2025
  15. Junio C HamanoDec 17, 2025
  16. Elijah NewrenDec 17, 2025
  17. Johannes SixtDec 17, 2025
  18. Junio C HamanoDec 17, 2025
  19. Kristoffer HaugsbakkDec 19, 2025
  20. Junio C HamanoDec 19, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.