Re: [PATCH v2] commit: document that $command.signoff will not be added
- From
Elijah Newren <newren@gmail.com>
- Date
- Dec 17, 2025, 07:40 UTC
- Message-ID
- <CABPp-BF=W_y7KFZBWbsDMAeM8+OWH4fJjfCzavPeaDT6UZoNRA@mail.gmail.com>
- In-Reply-To
- <xmqqike53ea7.fsf@gitster.g>
On Tue, Dec 16, 2025 at 8:47 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> > Elijah Newren <newren@gmail.com> writes: > > > I like Johannes' edits to the text I had; this commit looks good to me. > > If you liked the final result, it probably should not matter much, > but I cannot tell if you are (obliquely) pointing out that I failed > to grab and apply Johannes's edit or if you are doubly agreeing with > the resulting text in the message you are responding to.
Um, I read Johannes' suggested edit and this patch and thought they matched. I just re-read them now, and don't see any edits that you missed. Am I missing something in his email, or another email of his?
Anyway, sorry, I guess I should have inserted a "so" right after the semicolon ("...had; so, this commit looks good to me.)"