Re: [PATCH/RFC] Revert "git am/mailinfo: Don't look at in-body headers when rebasing"

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 24, 2015, 16:04 UTC
Message-ID: <xmqq616day9j.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CACRoPnRFCZWih-uFMRnqWwOCmeM9=RgUUpQURk4vrZZsDOjGvg@mail.gmail.com>

Paul Tan <pyokagan@gmail.com> writes:

Show 16 quoted lines

> On Tue, Jun 16, 2015 at 5:03 PM, Paul Tan <pyokagan@gmail.com> wrote:
>> This reverts commit d25e51596be9271ad833805a3d6f9012dc24ee79, removing
>> git-mailsplit's --no-inbody-headers option.
>>
>> While --no-inbody-headers was introduced to prevent commit messages from
>> being munged by git-mailinfo while rebasing, the need for this option
>> disappeared since 5e835ca (rebase: do not munge commit log message,
>> 2008-04-16), as git-am bypasses git-mailinfo and gets the commit message
>> directly from the commit ID in the patch.
>>
>> git-am is the only user of --no-inbody-headers, and this option is not
>> documented. As such, it should be removed.
>>
>> Signed-off-by: Paul Tan <pyokagan@gmail.com>
>
> What do you think about applying this patch?

Indifferent, even though it would be the right thing to do in the longer term.

Keeping what we think nobody uses does not hurt us at least in the short term; removing such a thing hurts us if it turns out that somebody whose use we didn't know about were actually using it.

And my time is better spent at this point in the cycle on other things than having to worry about possible fallouts from the removal that is not urgent.