Re: [PATCH/RFC] Revert "git am/mailinfo: Don't look at in-body headers when rebasing"

From: Paul Tan <pyokagan@gmail.com>
Date: Jun 24, 2015, 10:36 UTC
Message-ID: <CACRoPnRFCZWih-uFMRnqWwOCmeM9=RgUUpQURk4vrZZsDOjGvg@mail.gmail.com>
In-Reply-To: <1434445392-6265-1-git-send-email-pyokagan@gmail.com>

Hi Junio,

On Tue, Jun 16, 2015 at 5:03 PM, Paul Tan <pyokagan@gmail.com> wrote:

Show 13 quoted lines

> This reverts commit d25e51596be9271ad833805a3d6f9012dc24ee79, removing
> git-mailsplit's --no-inbody-headers option.
>
> While --no-inbody-headers was introduced to prevent commit messages from
> being munged by git-mailinfo while rebasing, the need for this option
> disappeared since 5e835ca (rebase: do not munge commit log message,
> 2008-04-16), as git-am bypasses git-mailinfo and gets the commit message
> directly from the commit ID in the patch.
>
> git-am is the only user of --no-inbody-headers, and this option is not
> documented. As such, it should be removed.
>
> Signed-off-by: Paul Tan <pyokagan@gmail.com>

What do you think about applying this patch?

Either way, the no-inbody-headers code in git-am.sh is dead code so I don't think I will be implementing it in the git-am rewrite.

Thanks, Paul