Re: [PATCH/RFC] Revert "git am/mailinfo: Don't look at in-body headers when rebasing"

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 16, 2015, 09:47 UTC
Message-ID: <e9f6878d93bc7946be9116f02f023d64@www.dscho.org>
In-Reply-To: <1434445392-6265-1-git-send-email-pyokagan@gmail.com>

Hi Paul,

On 2015-06-16 11:03, Paul Tan wrote:

Show 11 quoted lines

> This reverts commit d25e51596be9271ad833805a3d6f9012dc24ee79, removing
> git-mailsplit's --no-inbody-headers option.
> 
> While --no-inbody-headers was introduced to prevent commit messages from
> being munged by git-mailinfo while rebasing, the need for this option
> disappeared since 5e835ca (rebase: do not munge commit log message,
> 2008-04-16), as git-am bypasses git-mailinfo and gets the commit message
> directly from the commit ID in the patch.
> 
> git-am is the only user of --no-inbody-headers, and this option is not
> documented. As such, it should be removed.

Makes sense to me.

Show 6 quoted lines

> Notes:
>     The other direction, of course, is to turn --no-inbody-headers into a
>     supported, documented option in both git-mailsplit and git-am.
>     
>     I do also wonder if we should just ensure that git-format-patch does not
>     generate a message that start with "From" or "Date".

In case we need this option for anything in the future, we can easily resurrect it from the commit history, so removing the option the appropriate course of action, methinks.

Ciao, Dscho