Re: [PATCH v2 2/2] check_everything_connected: assume alternate ref tips are valid

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 3, 2019, 16:46 UTC
Message-ID: <xmqq5zoj2hi6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190703164116.GA23260@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> On Wed, Jul 03, 2019 at 11:12:25AM +0200, SZEDER Gábor wrote:
>
>> On Mon, Jul 01, 2019 at 09:18:15AM -0400, Jeff King wrote:
>> > diff --git a/t/t5618-alternate-refs.sh b/t/t5618-alternate-refs.sh
>> > new file mode 100755
>> > index 0000000000..3353216f09
>> > --- /dev/null
>> > +++ b/t/t5618-alternate-refs.sh
>> > @@ -0,0 +1,60 @@
>> 
>> > +test_expect_success 'log --source shows .alternate marker' '
>> > +	git log --oneline --source --remotes=origin >expect.orig &&
>> > +	sed "s/origin.* /.alternate /" <expect.orig >expect &&
>> 
>> Unnecessary redirection, 'sed' can open that file on its own as well.
>
> Sure, but is there a compelling reason not to feed it as stdin?

FWIW I do not think it is bad to redirect into a command at all ;-)