Re: [PATCH 1/2] object-store.h: move for_each_alternate_ref() from transport.h

From: Derrick Stolee <stolee@gmail.com>
Date: Jul 1, 2019, 13:23 UTC
Message-ID: <877673cb-5b2b-6e65-9a03-a16de043990d@gmail.com>
In-Reply-To: <20190701131740.GA2584@sigill.intra.peff.net>

On 7/1/2019 9:17 AM, Jeff King wrote:

Show 8 quoted lines

> There's nothing inherently transport-related about enumerating the
> alternate ref tips. The code has lived in transport.[ch] because the
> only use so far had been advertising available tips during transport.
> But it could be used for more, and a future patch will teach rev-list to
> access these refs.
> 
> Let's move it alongside the other alt-odb code, declaring it in
> object-store.h with the implementation in sha1-file.c.

Thanks!

> This lets us drop the inclusion of transport.h from receive-pack, which
> perhaps shows how it was misplaced (though receive-pack is about
> transporting objects, transport.h is mostly about the client side).

That's an interesting de-coupling. Thanks for looking into reorganizing the code. This series looks good to me.

-Stolee