git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] check_everything_connected: assume alternate ref tips are valid

From
Jeff King <peff@peff.net>
Date
Jul 1, 2019, 12:59 UTC
Message-ID
<20190701125945.GB4704@sigill.intra.peff.net>
In-Reply-To
<418213f2-82d6-f7bd-7379-7f20f0e83084@gmail.com>
On Mon, Jul 01, 2019 at 08:25:09AM -0400, Derrick Stolee wrote:
Show 8 quoted lines
> > I'm not sure what you have in mind, exactly. If you are asking whether
> > there are more places that alternate refs could be used, I can't think
> > of any. If you are asking whether this is in the wrong place, no, I
> > think it's the right place. :)
> 
> Just double-checking that it is appropriate for revision.c to take
> dependence on transport.h instead of moving the alternate ref stuff
> into a different header file. I trust your opinion.
Ah, I see. I misunderstood you before.

Yes, this is weakening the ties of the feature to the transport code. Traditionally transport-oriented code was the only user, but it also used the upload-pack transport under the hood to access the alternate (that was changed a while ago to for-each-ref for speed).

I don't think there's any functional difference in having it there, but it could be moved to live alongside foreach_alt_odb() in sha1-file.c.

-Peff
Previous: Derrick StoleeNext: Jeff King
Message 6 of 20 in “check_everything_connected: assume alternate ref tips are valid”
  1. check_everything_connected: assume alternate ref tips are validJeff King, Jun 28, 2019
  2. Jeff KingJun 28, 2019
  3. Derrick StoleeJun 28, 2019
  4. Jeff KingJun 29, 2019
  5. Derrick StoleeJul 1, 2019
  6. Jeff KingJul 1, 2019
  7. Jeff KingJul 1, 2019
  8. 1/2 object-store.h: move for_each_alternate_ref() from transport.hJeff King, Jul 1, 2019
  9. Derrick StoleeJul 1, 2019
  10. 2/2 check_everything_connected: assume alternate ref tips are validJeff King, Jul 1, 2019
  11. SZEDER GáborJul 3, 2019
  12. Jeff KingJul 3, 2019
  13. Junio C HamanoJul 3, 2019
  14. SZEDER GáborJul 3, 2019
  15. Junio C HamanoJul 3, 2019
  16. Taylor BlauJul 1, 2019
  17. Jeff KingJul 2, 2019
  18. Junio C HamanoJun 28, 2019
  19. Jeff KingJun 29, 2019
  20. Derrick StoleeJul 1, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.