Re: mr/bisect-in-c-3, was Re: What's cooking in git.git (Oct 2020, #03; Mon, 19)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 21, 2020, 20:44 UTC
Message-ID: <xmqq5z7371i2.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2010211647050.56@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 19 quoted lines

> Hi Junio,
>
> On Mon, 19 Oct 2020, Junio C Hamano wrote:
>
>> * mr/bisect-in-c-3 (2020-10-16) 7 commits
>>  - bisect--helper: retire `--bisect-autostart` subcommand
>>  - bisect--helper: retire `--write-terms` subcommand
>>  - bisect--helper: retire `--check-expected-revs` subcommand
>>  - bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C
>>  - bisect--helper: retire `--next-all` subcommand
>>  - bisect--helper: retire `--bisect-clean-state` subcommand
>>  - bisect--helper: finish porting `bisect_start()` to C
>>
>>  Rewriting "git bisect" in C continues.
>>
>>  How ready is this one?
>
> It has been reviewed _quite_ a couple of times over the course of 9
> iterations, and I think it is ready now.

Oh, numbers I can count. I wanted to hear "yes, all previously known issues have been addressed" from those who did read everything in it and gave their feedback.

Do you want to give your "reviewed-by" now?

Thanks.