From: Junio C Hamano Date: Wed, 21 Oct 2020 20:44:21 GMT Subject: Re: mr/bisect-in-c-3, was Re: What's cooking in git.git (Oct 2020, #03; Mon, 19) Message-ID: In-Reply-To: Johannes Schindelin writes: > Hi Junio, > > On Mon, 19 Oct 2020, Junio C Hamano wrote: > >> * mr/bisect-in-c-3 (2020-10-16) 7 commits >> - bisect--helper: retire `--bisect-autostart` subcommand >> - bisect--helper: retire `--write-terms` subcommand >> - bisect--helper: retire `--check-expected-revs` subcommand >> - bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C >> - bisect--helper: retire `--next-all` subcommand >> - bisect--helper: retire `--bisect-clean-state` subcommand >> - bisect--helper: finish porting `bisect_start()` to C >> >> Rewriting "git bisect" in C continues. >> >> How ready is this one? > > It has been reviewed _quite_ a couple of times over the course of 9 > iterations, and I think it is ready now. Oh, numbers I can count. I wanted to hear "yes, all previously known issues have been addressed" from those who did read everything in it and gave their feedback. Do you want to give your "reviewed-by" now? Thanks.