Re: ak/corrected-commit-date, was Re: What's cooking in git.git (Oct 2020, #03; Mon, 19)

From: Jakub Narębski <jnareb@gmail.com>
Date: Oct 23, 2020, 14:39 UTC
Message-ID: <685afed6-f01f-5d22-80d4-00fdc11caf0a@gmail.com>
In-Reply-To: <xmqqr1put77h.fsf@gitster.c.googlers.com>

On 19.10.2020 at 20:13, Junio C Hamano wrote:

Show 16 quoted lines

> * ak/corrected-commit-date (2020-10-08) 10 commits
>   - doc: add corrected commit date info
>   - commit-reach: use corrected commit dates in paint_down_to_common()
>   - commit-graph: use generation v2 only if entire chain does
>   - commit-graph: implement generation data chunk
>   - commit-graph: implement corrected commit date
>   - commit-graph: add a slab to store topological levels
>   - commit-graph: return 64-bit generation number
>   - commit-graph: consolidate fill_commit_graph_info
>   - revision: parse parent in indegree_walk_step()
>   - commit-graph: fix regression when computing Bloom filters
> 
>   The commit-graph learned to use corrected commit dates instead of
>   the generation number to help topological revision traversal.
> 
>   How ready is this?

I am reviewing this patch series; it looks good, in a few places explanation in the commit message needs improvement.

I think we could in patch 07/10 get a better performance for GDOV (overflow chunk for generation numbers) writing with an alternate approach, but that might wait for subsequent patch series.

Best,

-- 
Jakub Narębski