Re: [PATCH 2/3] shorten_unambiguous_ref(): use NUM_REV_PARSE_RULES constant

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2023, 21:34 UTC
Message-ID: <xmqq5yc453u5.fsf@gitster.g>
In-Reply-To: <Y+vVkhB59XYys4C7@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The current count-up isn't a big deal, as we need to preprocess that
> array anyway. But it will become more cumbersome as we refactor the
> shortening code. So let's get rid of it and just use the constant
> everywhere.

OK. As the array is constant, we could lose its NULL-termination and -1 from the definition of NUM_REV_PARSE_RULES, but that has iffy upside, and can come on top of the series if we really wanted to.

Looking good so far.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.