Re: [PATCH v2 3/3] shorten_unambiguous_ref(): avoid sscanf()
- From
Jeff King <peff@peff.net>
- Date
- Feb 16, 2023, 17:31 UTC
- Message-ID
- <Y+5ohGA6NKNi6Di6@coredump.intra.peff.net>
- In-Reply-To
- <20230216055641.brlx3os2ucj3ywer@tb-raspi4>
On Thu, Feb 16, 2023 at 06:56:41AM +0100, Torsten Bögershausen wrote:
> Does it make sense to > a) Use the local locale, what ever that is
It is always "C", because that's what our tests do. And we found that wasn't particularly interesting to this case.
> b) Re-run with LC_ALL=en_US.UTF-8
That part's what we already do, and...
> c) Re-run with LANG=C (that is where I had suspected problems when using UTF-8)
This won't do anything, because we set LC_ALL in the test scripts, which takes precedence over LANG. Eric used it in his real-world testing because he quite sensibly does not have LC_ALL set in his usual shell. :)
> d) Mention MacOs here ?
Yup, discussed downthread.
-Peff