Re: [PATCH 2/3] shorten_unambiguous_ref(): use NUM_REV_PARSE_RULES constant
- From
Jeff King <peff@peff.net>
- Date
- Feb 14, 2023, 22:23 UTC
- Message-ID
- <Y+wJ62wwAcuvBRYi@coredump.intra.peff.net>
- In-Reply-To
- <xmqq5yc453u5.fsf@gitster.g>
On Tue, Feb 14, 2023 at 01:34:10PM -0800, Junio C Hamano wrote:
Show 10 quoted lines
> Jeff King <peff@peff.net> writes: > > > The current count-up isn't a big deal, as we need to preprocess that > > array anyway. But it will become more cumbersome as we refactor the > > shortening code. So let's get rid of it and just use the constant > > everywhere. > > OK. As the array is constant, we could lose its NULL-termination > and -1 from the definition of NUM_REV_PARSE_RULES, but that has iffy > upside, and can come on top of the series if we really wanted to.
Yeah. We'd have to update the other callers. Not hard, but I agree it doesn't buy us much.
-Peff