Re: [PATCH] git-send-email.perl: avoid printing undef when validating addresses

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 18, 2023, 19:04 UTC
Message-ID: <xmqq5y47l2vg.fsf@gitster.g>
In-Reply-To: <545729b619308c6f3397b9aa1747f26ddc58f461.1695054945.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

Show 12 quoted lines

> diff --git a/git-send-email.perl b/git-send-email.perl
> index 897cea6564..288ea1ae80 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1166,10 +1166,10 @@ sub extract_valid_address {
>  
>  sub extract_valid_address_or_die {
>  	my $address = shift;
> +	my $valid_address = extract_valid_address($address);
>  	die sprintf(__("error: unable to extract a valid address from: %s\n"), $address)
> +		if !$valid_address;
> +	return $valid_address;

This will still use undef if the incoming $address is already undef, but the caller deserves what it gets in such a case. The message reports that the %s is the source from which the code tried to extract the address from, not the result of failed extraction, so the rewrite is absolutely the right thing to do.

Will queue.  Thanks.

>  }
>  
>  sub validate_address {