git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [REGRESSION] uninitialized value $address in git send-email

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Sep 20, 2023, 11:00 UTC
Message-ID
<ZQrQsa5GJEVhBttT@debian.me>
In-Reply-To
<118975ef-c07f-c397-5288-7698e60516a7@amd.com>
On Tue, Sep 19, 2023 at 10:37:36AM -0400, Michael Strawbridge wrote:
Show 7 quoted lines
> I suppose I may have mistook what issue was being reported.  I had
> originally understood the problem to be that hook related logic was
> failing with correct email addresses, but it seems rather that we are
> trying to fix an error that occurs when an email address that fails
> extract_valid_address_or_die() is given.  Feel free to ignore my last
> email if that is all we are trying to solve.
> 

Originally, I was intended to report regression on handling multiple addresses passed in a single --to/--cc/--bcc option. Previously on Git v2.40, git-send-email(1) accepts `--to="foo <foo@foo.com>,bar <bar@bar.com>" as two separate --to addresses (with comma as separator). However, on v2.41 and up, instead I got perl error as I reported in this thread. Interestingly, that perl error can be reduced into one invalid addresses. The same thing also happens to --cc and --bcc. I used aforementioned trick when I was sending patches to LKML to save frin typing the same option multiple times, each with different address.

If I need to send separate regression report for above use case, please let me know.

-- 
An old man doll... just what I always wanted! - Clara
Previous: Michael StrawbridgeNext: Michael Strawbridge
Message 9 of 15 in “[REGRESSION] uninitialized value $address in git send-email”
  1. Bagas SanjayaSep 18, 2023
  2. git-send-email.perl: avoid printing undef when validating addressesTaylor Blau, Sep 18, 2023
  3. Junio C HamanoSep 18, 2023
  4. Jeff KingSep 18, 2023
  5. Michael StrawbridgeSep 18, 2023
  6. Bagas SanjayaSep 19, 2023
  7. Michael StrawbridgeSep 19, 2023
  8. Michael StrawbridgeSep 19, 2023
  9. Bagas SanjayaSep 20, 2023
  10. Michael StrawbridgeSep 20, 2023
  11. Junio C HamanoSep 20, 2023
  12. Bagas SanjayaSep 21, 2023
  13. Junio C HamanoSep 21, 2023
  14. Bagas SanjayaSep 22, 2023
  15. Junio C HamanoSep 20, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.