Re: [REGRESSION] uninitialized value $address in git send-email

From: Michael Strawbridge <michael.strawbridge@amd.com>
Date: Sep 20, 2023, 13:14 UTC
Message-ID: <c15a6561-3105-df16-b74b-99e5dad63fa8@amd.com>
In-Reply-To: <ZQrQsa5GJEVhBttT@debian.me>

On 2023-09-20 07:00, Bagas Sanjaya wrote:

Show 21 quoted lines

> On Tue, Sep 19, 2023 at 10:37:36AM -0400, Michael Strawbridge wrote:
>> I suppose I may have mistook what issue was being reported.  I had
>> originally understood the problem to be that hook related logic was
>> failing with correct email addresses, but it seems rather that we are
>> trying to fix an error that occurs when an email address that fails
>> extract_valid_address_or_die() is given.  Feel free to ignore my last
>> email if that is all we are trying to solve.
>>
> Originally, I was intended to report regression on handling multiple
> addresses passed in a single --to/--cc/--bcc option. Previously on Git v2.40,
> git-send-email(1) accepts `--to="foo <foo@foo.com>,bar <bar@bar.com>"
> as two separate --to addresses (with comma as separator). However, on
> v2.41 and up, instead I got perl error as I reported in this thread.
> Interestingly, that perl error can be reduced into one invalid addresses.
> The same thing also happens to --cc and --bcc. I used aforementioned
> trick when I was sending patches to LKML to save frin typing the same
> option multiple times, each with different address.
>
> If I need to send separate regression report for above use case,
> please let me know.
>

I'm probably not the best person to answer whether you should file another report. Junio would know better the processes of this mailing list.

However, I believe that if you are just trying to have the "uninitialized value $address" error disappear then the above patch by Taylor Blau should work great. Feel free to try it by editing your local copy of git-send-email usually found here: /usr/lib/git-core/git-send-email