Re: [PATCH v4 10/12] refs: implement removal of ref storages

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 5, 2024, 16:54 UTC
Message-ID: <xmqq5xunuy8l.fsf@gitster.g>
In-Reply-To: <20240605101200.GA3440499@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> If removing either of the directories fails, we set ret to "-1". Make
> sense. But...
>
>> +	ret = for_each_root_ref(refs, remove_one_root_ref, &data);
>> +	if (ret < 0)
>> +		ret = -1;
>
> ...then we unconditionally overwrite it, forgetting the earlier error.

Ouch.

Show 7 quoted lines

> Is that a mistake, or are we normalizing other negative values? Maybe
> just:
>
>   if (for_each_root_ref(refs, remove_one_root_ref, &data) < 0)
> 	ret = -1;
>
> would work?

Sounds sensible.

Thanks for carefully reading.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.