Re: [PATCH v2 1/9] setup: unset ref storage when reinitializing repository version

From: Patrick Steinhardt <ps@pks.im>
Date: May 28, 2024, 05:13 UTC
Message-ID: <ZlVoEi2gi9JQSzSO@tanuki>
In-Reply-To: <yl4wqgtcfapjxuknb57sevnoi4jbcjnp3l6vqa7criqv2upq5p@x4hm33ymxukk>

On Fri, May 24, 2024 at 04:33:51PM -0500, Justin Tobler wrote:

Show 13 quoted lines

> On 24/05/24 12:14PM, Patrick Steinhardt wrote:
> > When reinitializing a repository's version we may end up unsetting the
> > hash algorithm when it matches the default hash algorithm. If we didn't
> > do that then the previously configured value might remain intact.
> > 
> > While the same issue exists for the ref storage extension, we don't do
> > this here. This has been fine for most of the part because it is not
> > supported to re-initialize a repository with a different ref storage
> > format anyway. We're about to introduce a new command to migrate ref
> > storages though, so this is about to become an issue there.
> 
> Ah, so this would be important in the context of migrating a repository
> from "reftable" to "files".

Exactly.

> > Prepare for this and unset the ref storage format when reinitializing a
> > repoistory with the "files" format.
> 
> s/repoistory/repository/

Thanks, fixed.

Patrick