Re: [PATCH v4 06/12] refs/files: extract function to iterate through root refs

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 6, 2024, 04:50 UTC
Message-ID: <ZmFAMBhkuUQEhgCR@tanuki>
In-Reply-To: <20240605100728.GA3440281@coredump.intra.peff.net>

On Wed, Jun 05, 2024 at 06:07:28AM -0400, Jeff King wrote:

Show 14 quoted lines

> On Mon, Jun 03, 2024 at 11:30:35AM +0200, Patrick Steinhardt wrote:
> 
> > +static int for_each_root_ref(struct files_ref_store *refs,
> > +			     int (*cb)(const char *refname, void *cb_data),
> > +			     void *cb_data)
> >  {
> >  	struct strbuf path = STRBUF_INIT, refname = STRBUF_INIT;
> >  	const char *dirname = refs->loose->root->name;
> >  	struct dirent *de;
> >  	size_t dirnamelen;
> > +	int ret;
> >  	DIR *d;
> 
> Should we initialize ret to 0 here?

Yeah, we should. Or rather, I'll set `ret = 0;` on the successful path.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.