Re: [PATCH v2 1/9] object-file: move `safe_create_leading_directories()` into "dir.c"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 11, 2025, 20:09 UTC
- Message-ID
- <xmqq5xjampdc.fsf@gitster.g>
- In-Reply-To
- <20250411-pks-split-object-file-v2-1-2bea0c9033ae@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> The `safe_create_leading_directories()` function and its relatives are > located in "object-file.c", which is not a good fit as they provide > generic functionality not related to objects at all. Move them into > "dir.c".
It may be debatable that <dir.c>, which has traditionally been a collection of read-only operations (mostly for exclude/ignore processing), is a good place to host "mkdir -p", but it certainly is better than having it in <object-file.c>
Looking good.