Re: [PATCH 1/9] object-file: move `safe_create_leading_directories()` into "dir.c"

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 11, 2025, 09:27 UTC
Message-ID: <Z_jgdV7Tkw0hkvgj@pks.im>
In-Reply-To: <CABPp-BFpU5iLUN6Fh_+UG2Y593TWp4E+C_QQxLg6b=Cb-30F6A@mail.gmail.com>

On Wed, Apr 09, 2025 at 07:36:47AM -0700, Elijah Newren wrote:

Show 9 quoted lines

> On Tue, Apr 8, 2025 at 3:37 AM Patrick Steinhardt <ps@pks.im> wrote:
> >
> > The `safe_create_leading_directories()` function and its relatives
> 
> How is mkdir_in_gitdir() a relative of safe_create_leading_directories()?
> 
> I assumed the relation was "called by", but there is no such
> relationship.  The rest of the patch looked fine, but I was puzzled
> for a while trying to figure out what this relationship is.

It's more of a sibling than a child/parent in this case, true. I still think it makes sense to move it around as it is rather generic in the functionality it provides and doesn't have anything to do with objects.

Patrick