Re: [PATCH v5 8/9] pack-objects: introduce '--stdin-packs=follow'

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 20, 2025, 15:27 UTC
Message-ID: <xmqq5xgq5t6s.fsf@gitster.g>
In-Reply-To: <b81b6213e8f98968a98bd147c068090cfadb5f92.1750375803.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

Show 5 quoted lines

> +	enum stdin_packs_mode mode = *(enum stdin_packs_mode *)data;
> +	if (mode == STDIN_PACKS_MODE_FOLLOW) {
> +		if (object->type == OBJ_BLOB && !has_object(the_repository,
> +							    &object->oid, 0))
> +			return;

Sorry for making a comment that is not about the contents of the patch, but since we were discussing clang-format elsewhere, and this happens to be a case the tool gets it right, the above should read more like:

		if (object->type == OBJ_BLOB &&
		    !has_object(the_repository, &object->oid, 0))
			return;

cf. Documentation/CodingGuidelines

 - When splitting a long logical line, with everything else being
   equal, it is preferable to split after the operator at higher
   level in the parse tree.