[PATCH v3 7/9] pack-objects: swap 'show_{object,commit}_pack_hint'
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Apr 15, 2025, 22:47 UTC
- Message-ID
- <6c997853f15deb03a7b55577316720c40573be9b.1744757204.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1744757204.git.me@ttaylorr.com>
show_commit_pack_hint() has heretofore been a noop, so its position within its compilation unit only needs to appear before its first use.
But the following commit will sometimes have `show_commit_pack_hint()` call `show_object_pack_hint()`, so reorder the former to appear after the latter to minimize the code movement in that patch.
Suggested-by: Elijah Newren <newren@gmail.com> Signed-off-by: Taylor Blau <me@ttaylorr.com> --- builtin/pack-objects.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index f06b359150..f4009cd391 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -3513,12 +3513,6 @@ static int add_object_entry_from_pack(const struct object_id *oid, return 0; } -static void show_commit_pack_hint(struct commit *commit UNUSED, - void *data UNUSED) -{ - /* nothing to do; commits don't have a namehash */ -} - static void show_object_pack_hint(struct object *object, const char *name, void *data UNUSED) { @@ -3541,6 +3535,12 @@ static void show_object_pack_hint(struct object *object, const char *name, stdin_packs_hints_nr++; } +static void show_commit_pack_hint(struct commit *commit UNUSED, + void *data UNUSED) +{ + /* nothing to do; commits don't have a namehash */ +} + static int pack_mtime_cmp(const void *_a, const void *_b) { struct packed_git *a = ((const struct string_list_item*)_a)->util;
-- 2.49.0.230.ga662d77f78