Re: [PATCH v2 7/8] pack-objects: introduce '--stdin-packs=follow'

> > > @@ -4467,6 +4484,23 @@ static int is_not_in_promisor_pack(struct commit *commit, void *data) {
> > >         return is_not_in_promisor_pack_obj((struct object *) commit, data);
> > >  }
> > >
> > > +static int parse_stdin_packs_mode(const struct option *opt, const char *arg,
> > > +                                 int unset)
> > > +{
> > > +       enum stdin_packs_mode *mode = opt->value;
> > > +
> > > +       if (unset)
> > > +               *mode = STDIN_PACKS_MODE_NONE;
> > > +       else if (!arg || !*arg)
> > > +               *mode = STDIN_PACKS_MODE_STANDARD;
> >
> > I don't understand why you have both a None mode and a Standard mode,
> > especially since the implementation seems to only care about whether
> > or not the Follow mode has been set.  Shouldn't these both be setting
> > mode to the same value?
>
> I'm not sure I follow your question... stdin_packs is a tri-state. It
> can be off, on in standard/legacy mode, or on in follow mode.