git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] Move rust gitcore crate to a different subdirectory

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 10, 2026, 17:45 UTC
Message-ID
<xmqq5x0df19l.fsf@gitster.g>
In-Reply-To
<20260910121056.2749578-1-mh@glandium.org>
Mike Hommey <mh@glandium.org> writes:
> Subject: Re: [PATCH v4] Move rust gitcore crate to a different subdirectory
Documentation/SubmittingPatches::[[summary-section]]
Show 13 quoted lines
> Having `Cargo.toml` at the top-level of the repository implies that one
> can run `cargo build` directly, but this doesn't produce anything useful
> on its own.
>
> Additionally, when including the git source as a submodule of a Rust
> project, it prevents the git source from being included at all in the
> crate package because cargo skips directories that contain a Cargo.toml,
> assuming that everything in the directory is relevant to the crate.
>
> Move all Rust-specific files into a dedicated `rust/` subdirectory.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
This still leaves the source tree in somewhat inconsistent state.
https://github.com/git/git/actions/runs/34505483626/job/102966561269#step:5:120

I do not offhand know if ci/run-rust-checks.sh needs updating or the moving of files needs tweaking to avoid the breakage, though.

Previous: Mike HommeyNext: Mike Hommey
Message 15 of 18 in “Move rust gitcore crate to a different subdirectory”
  1. Move rust gitcore crate to a different subdirectoryMike Hommey, Feb 4, 2026
  2. brian m. carlsonFeb 5, 2026
  3. Mike HommeyFeb 5, 2026
  4. brian m. carlsonFeb 5, 2026
  5. Mike HommeyFeb 5, 2026
  6. Move rust gitcore crate to a different subdirectoryMike Hommey, Feb 9, 2026
  7. Move rust gitcore crate to a different subdirectoryMike Hommey, Sep 9, 2026
  8. Junio C HamanoSep 9, 2026
  9. Mike HommeySep 10, 2026
  10. brian m. carlsonSep 9, 2026
  11. Mike HommeySep 10, 2026
  12. Tuomas AholaSep 10, 2026
  13. Junio C HamanoSep 10, 2026
  14. Move rust gitcore crate to a different subdirectoryMike Hommey, Sep 10, 2026
  15. Junio C HamanoSep 10, 2026
  16. move rust gitcore crate to a different subdirectoryMike Hommey, Sep 17, 2026
  17. Junio C HamanoSep 18, 2026
  18. Mike HommeySep 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.