From: Junio C Hamano Date: Thu, 10 Sep 2026 17:45:58 GMT Subject: Re: [PATCH v4] Move rust gitcore crate to a different subdirectory Message-ID: In-Reply-To: <20260910121056.2749578-1-mh@glandium.org> Mike Hommey writes: > Subject: Re: [PATCH v4] Move rust gitcore crate to a different subdirectory Documentation/SubmittingPatches::[[summary-section]] > Having `Cargo.toml` at the top-level of the repository implies that one > can run `cargo build` directly, but this doesn't produce anything useful > on its own. > > Additionally, when including the git source as a submodule of a Rust > project, it prevents the git source from being included at all in the > crate package because cargo skips directories that contain a Cargo.toml, > assuming that everything in the directory is relevant to the crate. > > Move all Rust-specific files into a dedicated `rust/` subdirectory. > > Signed-off-by: Mike Hommey > --- This still leaves the source tree in somewhat inconsistent state. https://github.com/git/git/actions/runs/34505483626/job/102966561269#step:5:120 I do not offhand know if ci/run-rust-checks.sh needs updating or the moving of files needs tweaking to avoid the breakage, though.