Re: [PATCH 2/2] make: delete strip target

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2021, 20:10 UTC
Message-ID: <xmqq4kbcdl0t.fsf@gitster.g>
In-Reply-To: <20210826113824.50078-3-bagasdotme@gmail.com>

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> The target isn't needed anymore since stripping is done in install-strip
> target (in previous patch).

That is not a valid justification.

People's automation may have been using a perfectly valid

	#!/bin/sh
	make test &&
	make doc &&
	make strip &&
	make install install-doc

and this patch will break them for no good reason.

We need to remember that just because we (think we) came up with a better way does not necessarily mean that we can immediately force our users to adopt the new way.

Show 17 quoted lines

> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b8a3a64422..027b052a0c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2170,8 +2170,6 @@ please_set_SHELL_PATH_to_a_more_modern_shell:
>  
>  shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell
>  
> -strip: $(PROGRAMS) git$X
> -	$(STRIP) $(STRIP_OPTS) $^
>  
>  ### Flags affecting all rules