Re: [PATCH 2/2] make: delete strip target

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 26, 2021, 19:36 UTC
Message-ID: <87bl5kyp4e.fsf@evledraar.gmail.com>
In-Reply-To: <20210826113824.50078-3-bagasdotme@gmail.com>

On Thu, Aug 26 2021, Bagas Sanjaya wrote:

Show 20 quoted lines

> The target isn't needed anymore since stripping is done in install-strip
> target (in previous patch).
>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b8a3a64422..027b052a0c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2170,8 +2170,6 @@ please_set_SHELL_PATH_to_a_more_modern_shell:
>  
>  shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell
>  
> -strip: $(PROGRAMS) git$X
> -	$(STRIP) $(STRIP_OPTS) $^
>  
>  ### Flags affecting all rules

This doesn't remove the phony "strip" target (nor does the first patch), and in any case I think this would be more readable with the two patches squashed together. Let's remove the old target & add the new one atomically.