Re: [PATCH 1/2] make: add install-stripped target
- From
Bagas Sanjaya <bagasdotme@gmail.com>
- Date
- Aug 27, 2021, 07:57 UTC
- Message-ID
- <b2005b0f-9181-526b-ebf5-58fca44299b5@gmail.com>
- In-Reply-To
- <xmqq8s0odl5l.fsf@gitster.g>
On 27/08/21 03.08, Junio C Hamano wrote:
Show 8 quoted lines
> It also depends on "strip" not to break handlinks to the same > binary. "git" is linked to many built-in command binary like > "git-cat-file" and "git-remote-$curl" for various protocols are > installed by creating links to "git-remote-http". It seems that the > "strip" command from GNU binutils package strips such a binary > in-place, but I do not think there is no fundamental reason to > believe that everybody else's "strip" would behave that way. >
Maybe hardlinks?
Show 8 quoted lines
> I would have expected that 'install-stripped' and 'install' targets > would run the same recipe, and when $(install_bindir_programs) are > installed in $(bindir) using $(INSTALL), we would optionally pass > the '--strip' option to the $(INSTALL) program when the recipe is > run for the install-stripped target. All the tricky symlinking, > hardlinking and copying happens only on the result of that step, and > the strip step should happen before that, I would think. >
Did you mean copying recipe of 'install' to 'install-stripped' and the latter s/$(INSTALL)/$(INSTALL -s --strip-program="$(STRIP)"/)?
-- An old man doll... just what I always wanted! - Clara