git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] make: add install-stripped target

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Aug 27, 2021, 07:57 UTC
Message-ID
<b2005b0f-9181-526b-ebf5-58fca44299b5@gmail.com>
In-Reply-To
<xmqq8s0odl5l.fsf@gitster.g>
On 27/08/21 03.08, Junio C Hamano wrote:
Show 8 quoted lines
> It also depends on "strip" not to break handlinks to the same
> binary.  "git" is linked to many built-in command binary like
> "git-cat-file" and "git-remote-$curl" for various protocols are
> installed by creating links to "git-remote-http".  It seems that the
> "strip" command from GNU binutils package strips such a binary
> in-place, but I do not think there is no fundamental reason to
> believe that everybody else's "strip" would behave that way.
> 
Maybe hardlinks?
Show 8 quoted lines
> I would have expected that 'install-stripped' and 'install' targets
> would run the same recipe, and when $(install_bindir_programs) are
> installed in $(bindir) using $(INSTALL), we would optionally pass
> the '--strip' option to the $(INSTALL) program when the recipe is
> run for the install-stripped target.  All the tricky symlinking,
> hardlinking and copying happens only on the result of that step, and
> the strip step should happen before that, I would think.
> 

Did you mean copying recipe of 'install' to 'install-stripped' and the latter s/$(INSTALL)/$(INSTALL -s --strip-program="$(STRIP)"/)?

-- 
An old man doll... just what I always wanted! - Clara
Previous: Junio C HamanoNext: Đoàn Trần Công Danh
Message 4 of 8 in “make: install stripped Git”
  1. 0/2 make: install stripped GitBagas Sanjaya, Aug 26, 2021
  2. 1/2 make: add install-stripped targetBagas Sanjaya, Aug 26, 2021
  3. Junio C HamanoAug 26, 2021
  4. Bagas SanjayaAug 27, 2021
  5. Đoàn Trần Công DanhAug 27, 2021
  6. 2/2 make: delete strip targetBagas Sanjaya, Aug 26, 2021
  7. Ævar Arnfjörð BjarmasonAug 26, 2021
  8. Junio C HamanoAug 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.