Re: [PATCH 1/6] maintenance: add get_random_minute()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 7, 2023, 23:53 UTC
- Message-ID
- <xmqq4jlabea3.fsf@gitster.g>
- In-Reply-To
- <ZNFgIyuhlNd8I9Y2@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
> I was wondering where else we call srand() within Git, and it looks like > the only other spot is in `lock_file_timeout()`.
lock_file_timeout() should be updated to match git_mkstemps_mode(), which was taught to use the csprng_bytes() function with 47efda96 (wrapper: use a CSPRNG to generate random file names, 2022-01-17), and this new caller may want to do so as well, perhaps? I dunno, but the caller then does not have to worry about "initializing it just once".