Re: [PATCH 6/6] maintenance: use random minute in systemd scheduler
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Aug 8, 2023, 17:14 UTC
- Message-ID
- <2e9b32a8-8905-4a1f-a75b-ca747ae95b96@github.com>
- In-Reply-To
- <d247ce48-e2ba-4915-8d96-1fa2f693909d@github.com>
On 8/8/2023 1:06 PM, Derrick Stolee wrote:
> On 8/8/2023 8:08 AM, Phillip Wood wrote: >> On 07/08/2023 19:51, Derrick Stolee via GitGitGadget wrote:
Show 5 quoted lines
>>> + char *local_timer_name = xstrfmt("git-maintenance@%s.timer", frequency);
>>
>> The "@" in the name signifies that it is a template unit which it isn't anymore so I think we want to change this to "git-maintenance-%s.timer"
>
> I'll also take your SYSTEMD_UNIT_FORMAT macro suggestion to simplify things.As I was checking things, it turns out that we _should_ keep the '@' symbol if only to make sure that our new schedule overwrites the old schedule.
The alternative is that we manually try to delete the old schedule, but that feels like an inefficient way to do it, leaving some cruft around long-term.
For completeness, here is what I did to check:
$ systemctl --user list-timers NEXT LEFT LAST PASSED UNIT ACTIVATES Tue 2023-08-08 13:13:00 EDT 6s left n/a n/a git-maintenance-hourly.timer git-maintenance-hourly.service Tue 2023-08-08 13:50:00 EDT 37min left Tue 2023-08-08 12:50:10 EDT 22min ago git-maintenance@hourly.timer git-maintenance@hourly.service Wed 2023-08-09 00:13:00 EDT 11h left n/a n/a git-maintenance-daily.timer git-maintenance-daily.service Wed 2023-08-09 00:50:00 EDT 11h left Tue 2023-08-08 09:35:31 EDT 3h 37min ago git-maintenance@daily.timer git-maintenance@daily.service Mon 2023-08-14 00:13:00 EDT 5 days left n/a n/a git-maintenance-weekly.timer git-maintenance-weekly.service Mon 2023-08-14 00:50:00 EDT 5 days left Mon 2023-08-07 10:28:10 EDT 1 day 2h ago git-maintenance@weekly.timer git-maintenance@weekly.service
Do you have an alternative idea how to handle that?
Thanks, -Stolee