git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] bugreport.c: fix a crash in git bugreport with --no-suffix option

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 14, 2024, 16:33 UTC
Message-ID
<xmqq4jd8ydqz.fsf@gitster.g>
In-Reply-To
<xmqqbk7gye0s.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> "barroit via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> executing git bugreport --no-suffix led to a segmentation fault due to
>> strbuf_addftime() being called with a NULL option_suffix variable. This
>> occurs because negating the "--[no-]suffix" option causes the parser to set
>> option_suffix to NULL, which is not handled prior to calling
>> strbuf_addftime().
>>
>> Jiamu Sun (2):
>>   bugreport.c: fix a crash in `git bugreport` with `--no-suffix` option
>>   doc: update doc file and usage for git-bugreport
>
> Squash them together into a single patch.  As you didn't have any
> meaningful log message in [2/2], unless there are other things that
> need to be updated and v3 is needed, I can squash them into one
> commit, though.
>
> Thanks for updating.

I forgot the two I CC'ed the review thread for the previous round to ping them, so here it is.

Thanks.
Previous: Junio C HamanoNext: Jiamu Sun
Message 9 of 12 in “bugreport.c: fix a crash in `git bugreport` with `--no-suffix` option”
  1. bugreport.c: fix a crash in `git bugreport` with `--no-suffix` optionbarroit via GitGitGadget, Mar 12, 2024
  2. Junio C HamanoMar 13, 2024
  3. Junio C HamanoMar 13, 2024
  4. Taylor BlauMar 16, 2024
  5. 0/2 bugreport.c: fix a crash in git bugreport with --no-suffix optionbarroit via GitGitGadget, Mar 14, 2024
  6. 1/2 bugreport.c: fix a crash in `git bugreport` with `--no-suffix` optionJiamu Sun via GitGitGadget, Mar 14, 2024
  7. 2/2 doc: update doc file and usage for git-bugreportJiamu Sun via GitGitGadget, Mar 14, 2024
  8. Junio C HamanoMar 14, 2024
  9. Junio C HamanoMar 14, 2024
  10. Jiamu SunMar 15, 2024
  11. bugreport.c: fix a crash in `git bugreport` with `--no-suffix` optionJiamu Sun, Mar 14, 2024
  12. Taylor BlauMar 16, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.