git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] bugreport.c: fix a crash in `git bugreport` with `--no-suffix` option

From
Taylor Blau <me@ttaylorr.com>
Date
Mar 16, 2024, 01:56 UTC
Message-ID
<ZfT8UiDM3DQhRX5x@nand.local>
In-Reply-To
<20240314223406.79283-1-barroit@linux.com>
On Fri, Mar 15, 2024 at 07:34:06AM +0900, Jiamu Sun wrote:
Show 12 quoted lines
> executing `git bugreport --no-suffix` led to a segmentation fault
> due to strbuf_addftime() being called with a NULL option_suffix
> variable. This occurs because negating the "--[no-]suffix" option
> causes the parser to set option_suffix to NULL, which is not
> handled prior to calling strbuf_addftime().
>
> By adding a NULL check, the `--no-suffix` option is now available.
> Using this option disables the suffix, and the file is just named
> `git-bugreport` without any disambiguation measure.
>
> Signed-off-by: Jiamu Sun <barroit@linux.com>
> ---
    Acked-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

Previous: Jiamu Sun
Message 12 of 12 in “bugreport.c: fix a crash in `git bugreport` with `--no-suffix` option”
  1. bugreport.c: fix a crash in `git bugreport` with `--no-suffix` optionbarroit via GitGitGadget, Mar 12, 2024
  2. Junio C HamanoMar 13, 2024
  3. Junio C HamanoMar 13, 2024
  4. Taylor BlauMar 16, 2024
  5. 0/2 bugreport.c: fix a crash in git bugreport with --no-suffix optionbarroit via GitGitGadget, Mar 14, 2024
  6. 1/2 bugreport.c: fix a crash in `git bugreport` with `--no-suffix` optionJiamu Sun via GitGitGadget, Mar 14, 2024
  7. 2/2 doc: update doc file and usage for git-bugreportJiamu Sun via GitGitGadget, Mar 14, 2024
  8. Junio C HamanoMar 14, 2024
  9. Junio C HamanoMar 14, 2024
  10. Jiamu SunMar 15, 2024
  11. bugreport.c: fix a crash in `git bugreport` with `--no-suffix` optionJiamu Sun, Mar 14, 2024
  12. Taylor BlauMar 16, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.