[PATCH v2 0/2] bugreport.c: fix a crash in git bugreport with --no-suffix option
- From
- barroit via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Mar 14, 2024, 04:00 UTC
- Message-ID
- <pull.1693.v2.git.1710388817.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1693.git.1710260812280.gitgitgadget@gmail.com>
executing git bugreport --no-suffix led to a segmentation fault due to strbuf_addftime() being called with a NULL option_suffix variable. This occurs because negating the "--[no-]suffix" option causes the parser to set option_suffix to NULL, which is not handled prior to calling strbuf_addftime().
Jiamu Sun (2): bugreport.c: fix a crash in `git bugreport` with `--no-suffix` option doc: update doc file and usage for git-bugreport
Documentation/git-bugreport.txt | 6 +++++- builtin/bugreport.c | 10 +++++++--- 2 files changed, 12 insertions(+), 4 deletions(-)
base-commit: 945115026aa63df4ab849ab14a04da31623abece Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1693%2Fbarroit%2Ffix-bugreport-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1693/barroit/fix-bugreport-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/1693
Range-diff vs v1:
1: 9c6f3f5203a = 1: 9c6f3f5203a bugreport.c: fix a crash in `git bugreport` with `--no-suffix` option -: ----------- > 2: 868cec05ed5 doc: update doc file and usage for git-bugreport
-- gitgitgadget