Re: [BUGREPORT] git diff-tree --cc SEGFAUTs

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2025, 02:55 UTC
Message-ID: <xmqq4j2fnv8p.fsf@gitster.g>
In-Reply-To: <20250104003154.GB3244554@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> ... OTOH it is not really
> solving the more fundamental problem, which is that p->parent[i].path is
> only sometimes useful (we do not fill it in if it would just be the same
> as p->path, so the patch only changes it from uninitialized memory into
> an empty strbuf).
>
> And that is probably not something we want to change, as allocating
> duplicates of each path may be expensive.

Nicely said. I reached the same conclusion after looking at the existing code, even though I have to admit that I am not a huge fan of the more recent part of combine-diff.c and its data structures.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.