From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 04 Jan 2025 02:55:18 GMT
Subject: Re: [BUGREPORT] git diff-tree --cc SEGFAUTs
Message-ID: <xmqq4j2fnv8p.fsf@gitster.g>
In-Reply-To: <20250104003154.GB3244554@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> ... OTOH it is not really
> solving the more fundamental problem, which is that p->parent[i].path is
> only sometimes useful (we do not fill it in if it would just be the same
> as p->path, so the patch only changes it from uninitialized memory into
> an empty strbuf).
>
> And that is probably not something we want to change, as allocating
> duplicates of each path may be expensive.

Nicely said.  I reached the same conclusion after looking at the
existing code, even though I have to admit that I am not a huge fan
of the more recent part of combine-diff.c and its data structures.

Thanks.