Re: [PATCH v7 7/7] builtin/clone: teach git-clone(1) the --revision= option

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2025, 20:26 UTC
Message-ID: <xmqq4j16kefu.fsf@gitster.g>
In-Reply-To: <Z6RvD4FtfXIk4Pa3@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 21 quoted lines

> On Thu, Feb 06, 2025 at 07:33:35AM +0100, Toon Claes wrote:
>> diff --git a/t/t5621-clone-revision.sh b/t/t5621-clone-revision.sh
>> new file mode 100755
>> index 0000000000000000000000000000000000000000..d4889a954e6300e0e327ebe7dfcf73569d966829
>> --- /dev/null
>> +++ b/t/t5621-clone-revision.sh
>> @@ -0,0 +1,123 @@
>> +#!/bin/sh
>> +
>> +test_description='tests for git clone --revision'
>> +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
>> +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
>> +
>> +TEST_PASSES_SANITIZE_LEAK=true
>
> One last nit: this line is not needed anymore, as tests are required to
> pass with the leak sanitizer by default now. Other than that this series
> looks good to me, and this change alone does not warrant a reroll from
> my point of view.
>
> Thanks!

I'll touch it up while queuing, and mark the topic for 'next', then.

Thanks.