Re: [PATCH v7 7/7] builtin/clone: teach git-clone(1) the --revision= option

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 6, 2025, 08:13 UTC
Message-ID: <Z6RvD4FtfXIk4Pa3@pks.im>
In-Reply-To: <20250206-toon-clone-refs-v7-7-4622b7392202@iotcl.com>

On Thu, Feb 06, 2025 at 07:33:35AM +0100, Toon Claes wrote:

Show 13 quoted lines

> diff --git a/t/t5621-clone-revision.sh b/t/t5621-clone-revision.sh
> new file mode 100755
> index 0000000000000000000000000000000000000000..d4889a954e6300e0e327ebe7dfcf73569d966829
> --- /dev/null
> +++ b/t/t5621-clone-revision.sh
> @@ -0,0 +1,123 @@
> +#!/bin/sh
> +
> +test_description='tests for git clone --revision'
> +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
> +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
> +
> +TEST_PASSES_SANITIZE_LEAK=true

One last nit: this line is not needed anymore, as tests are required to pass with the leak sanitizer by default now. Other than that this series looks good to me, and this change alone does not warrant a reroll from my point of view.

Thanks!

Patrick