Re: [PATCH v5 0/7] Enable doing a shallow clone of a specific git revision
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Feb 5, 2025, 08:03 UTC
- Message-ID
- <Z6MbPzpGdojU2g2f@pks.im>
- In-Reply-To
- <20250204-toon-clone-refs-v5-0-37e34af283c8@iotcl.com>
On Tue, Feb 04, 2025 at 10:33:59PM +0100, Toon Claes wrote:
Show 12 quoted lines
> Changes in v5: > - Add separate commit to introduce die_for_incompatible_opt2() > - Small tweaks in documentation about `--[no-]tags` and `--revision`. > - Better explain the refactoring of wanted_peer_refs() in the commit > message. > - Change type from `int` to `size_t` in wanted_peer_refs(). > - Use lookup_commit_or_die() instead lookup_commit_reference() to avoid > checking the result ourself. > - Add a few code comments to explain some things. > - Stylish cleanups like removal of unneeded empty lines, commented out > test-code and remarks. > - Link to v4: https://lore.kernel.org/r/20250131-toon-clone-refs-v4-0-2a4ff851498f@iotcl.com
I've got a couple more nits, but this version looks mostly good to me. Thanks!
Patrick