git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 0/2] Avoid submodule overwritten and skip redundant active entries

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2025, 22:34 UTC
Message-ID
<xmqq4ivn3a1w.fsf@gitster.g>
In-Reply-To
<20250608032705.11990-1-jayatheerthkulkarni2005@gmail.com>
K Jayatheerth <jayatheerthkulkarni2005@gmail.com> writes:
Show 24 quoted lines
> The first patch i.e. prevent overwriting .gitmodules entry on path reuse
> is exactly the same 
>
> The second patch however i.e. 
> skip redundant active entries when pattern covers path
> has changed logic 
> with the helper function being code maintainance because 
> of the duplicated logic. I've tried to wrap it as much as 
> possible to it's own core need without having to change it
> unless the core way of submodules addition and active status
> itself changes.
>
> The CI was tested in which 
> the only compiler error I found was 
> osx-gcc
> Which I suppose is already addressed,
> apart from this all of the other tests 
> ran successfully which includes the 
> t7413 (prvious 9) and the new one.
>
>
> K Jayatheerth (2):
>   submodule: prevent overwriting .gitmodules entry on path reuse
>   submodule: skip redundant active entries when pattern covers path

Haven't seen any comment from others on this topic for quite a while. How does this one look to those who do use submodules (I am not one of them)?

Thanks.
Previous: JAYATHEERTH K
Message 19 of 19 in “Avoid submodule overwritten and skip redundant active entries”
  1. 0/2 Avoid submodule overwritten and skip redundant active entriesK Jayatheerth, May 24, 2025
  2. 1/2 submodule: prevent overwriting .gitmodules entry on path reuseK Jayatheerth, May 24, 2025
  3. Junio C HamanoMay 27, 2025
  4. 2/2 submodule: skip redundant active entries when pattern covers pathK Jayatheerth, May 24, 2025
  5. Junio C HamanoMay 27, 2025
  6. JAYATHEERTH KMay 29, 2025
  7. Junio C HamanoJun 4, 2025
  8. JAYATHEERTH KJun 6, 2025
  9. 0/2 Avoid submodule overwritten and skip redundant active entriesK Jayatheerth, Jun 8, 2025
  10. 1/2 submodule: prevent overwriting .gitmodules entry on path reuseK Jayatheerth, Jun 8, 2025
  11. D. Ben KnobleJul 9, 2025
  12. JAYATHEERTH KJul 20, 2025
  13. Ben KnobleJul 25, 2025
  14. 2/2 submodule: skip redundant active entries when pattern covers pathK Jayatheerth, Jun 8, 2025
  15. D. Ben KnobleJul 9, 2025
  16. Junio C HamanoJul 9, 2025
  17. Junio C HamanoJul 17, 2025
  18. JAYATHEERTH KJul 18, 2025
  19. Junio C HamanoJul 7, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.