Re: [PATCH v8 2/2] submodule: skip redundant active entries when pattern covers path

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 9, 2025, 14:52 UTC
Message-ID: <xmqqqzyppgbi.fsf@gitster.g>
In-Reply-To: <CALnO6CAXermmya0UjTHU2gPoEAb1m32fOt7Uzf6CL2mSJ=RkTg@mail.gmail.com>

"D. Ben Knoble" <ben.knoble@gmail.com> writes:

Show 14 quoted lines

>> +test_expect_success 'submodule add skips redundant active entry' '
>> +       git init repo &&
>> +       (
>> +               cd repo &&
>> +               git config submodule.active "lib/*" &&
>> +               git commit --allow-empty -m init &&
>> +
>> +               git init ../lib-origin &&
>> +               git -C ../lib-origin commit --allow-empty -m init &&
>> +
>> +               git submodule add ../lib-origin lib/foo &&
>> +               ! git config --get submodule.lib/foo.active
>
> (Not my area of expertise) Should this be test_must_fail?

That is certainly better. "! git config ..." would succeed even when that command segfaults and dumps core, which we may want to notice.