From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 07 Jul 2025 22:34:03 GMT
Subject: Re: [PATCH v8 0/2] Avoid submodule overwritten and skip redundant active entries
Message-ID: <xmqq4ivn3a1w.fsf@gitster.g>
In-Reply-To: <20250608032705.11990-1-jayatheerthkulkarni2005@gmail.com>

K Jayatheerth <jayatheerthkulkarni2005@gmail.com> writes:

> The first patch i.e. prevent overwriting .gitmodules entry on path reuse
> is exactly the same 
>
> The second patch however i.e. 
> skip redundant active entries when pattern covers path
> has changed logic 
> with the helper function being code maintainance because 
> of the duplicated logic. I've tried to wrap it as much as 
> possible to it's own core need without having to change it
> unless the core way of submodules addition and active status
> itself changes.
>
> The CI was tested in which 
> the only compiler error I found was 
> osx-gcc
> Which I suppose is already addressed,
> apart from this all of the other tests 
> ran successfully which includes the 
> t7413 (prvious 9) and the new one.
>
>
> K Jayatheerth (2):
>   submodule: prevent overwriting .gitmodules entry on path reuse
>   submodule: skip redundant active entries when pattern covers path

Haven't seen any comment from others on this topic for quite a
while.  How does this one look to those who do use submodules (I am
not one of them)?

Thanks.