Re: [PATCH v4 5/6] connected: add incremental connectivity check via rev-list
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 23, 2026, 17:58 UTC
- Message-ID
- <xmqq4iec70yp.fsf@gitster.g>
- In-Reply-To
- <CAL71e4Ngsxv=JU_qzVGVyHPZiB2Qzvjn22NeVQAtZOdCr2vyXQ@mail.gmail.com>
Kristofer Karlsson <krka@spotify.com> writes:
> This ends up nicer than what I had -- I can also get rid of the > BUG() guard for checking that flag state.
That's great.
> Do you still want me to include this reasoning in the commit, > or is that now unnecessary given that it would no longer touch > fetch_if_missing?
I do not care too deeply, but the next person who wants to add a code to depend on fetch_if_missing may appreciate it, no?