Re: [PATCH v4 5/6] connected: add incremental connectivity check via rev-list
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Oct 22, 2026, 08:35 UTC
- Message-ID
- <CAL71e4MepqPJOqUQxoNc_8Q6PaWZwQX45tGZ2z4+iqGnNCDAEw@mail.gmail.com>
- In-Reply-To
- <CAL71e4Pe_NRxeu9_+pnp=pBOk3SBNyePUbT5DDtDhd1bJpwJng@mail.gmail.com>
On Thu, 22 Oct 2026 at 09:00, Kristofer Karlsson <krka@spotify.com> wrote:
Show 15 quoted lines
> > On Wed, 21 Oct 2026 at 22:18, Junio C Hamano <gitster@pobox.com> wrote: > > > > I wonder if this needs to be _extended() kind that passes a flag bit > > to avoid fetching from promisors. repo->fetch_if_missing that is > > set does prevent lazy fetching, but I wonder if it is better to be > > more explicit. > > Yes, and an earlier internal prototype (that I never sent) did > this. Blob and tree reads are easy to switch to > odb_read_object_info_extended() with OBJECT_INFO_SKIP_FETCH_OBJECT, > but parsing the parent commits goes through > repo_parse_commit_gently(), which has no such flag. That would > need a no-fetch flag passed down through commit parsing, which I > think is not too bad on its own.
Sorry, I think I was wrong about this part -- commit parsing never fetches. I think this means my initial problems were partly to die(). I will re-explore this and see if eliminating fetch_if_missing = 0 is less work than I first thought.