Re: [PATCH v3 3/4] connected: add transfer.connectivityCheck config and rev-list flag
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 15, 2026, 06:55 UTC
- Message-ID
- <atB49SAaLKS3lfGE@pks.im>
- In-Reply-To
- <cdf28f1df6cb36b006f367de0e18e23e3aa8d992.1791806877.git.gitgitgadget@gmail.com>
On Mon, Oct 12, 2026 at 12:07:56PM +0000, Kristofer Karlsson via GitGitGadget wrote:
Show 9 quoted lines
> From: Kristofer Karlsson <krka@spotify.com> > > Add the transfer.connectivityCheck configuration option, accepting > "full" (default) and "incremental". When set to "incremental", > check_connected() passes --verify-trees-incremental to its rev-list > subprocess. > > The rev-list flag is accepted but has no effect yet; the incremental > verification will be implemented in the next commit.
I think this step is a tiny bit awkward. My suggestion was rather aiming to introduce the configuration option, but initially only accept "full" for the current behaviour. The "--verify-trees-incremental" flag could then be implemented in the next commit, and the final commit would then tie all of this together by introducing the "incremental" value.
Patrick