git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 8/8] t/test-lib: make feature-testbed job more accessible

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 27, 2026, 20:59 UTC
Message-ID
<xmqq4ie6j1vw.fsf@gitster.g>
In-Reply-To
<1da30fde-75bf-469f-80e1-ce90cd29c84d@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 31 quoted lines
> That all sounds sensible, the commit message could maybe flag that the 
> "feature-testbed" also sets OPENSSL_SHA1_UNSAFE which 
> "--feature-testbed" does not because it is only concerned with GIT_TEST_*.
>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index de566309861..8863bcac930 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -202,6 +202,14 @@ finalize_test_case_output () { :; }
>>   finalize_test_leak_output () { :; }
>>   finalize_test_output () { :; }
>>   
>> +set_default_env () {
>> +	if eval "test -z \"\${$1+set}\""
>
> This made me scratch my head for a couple of minutes, but I think it is 
> correct
>
> 	set_default_env ABC 1
>
> evaluates
>
> 	test -z "${ABC+set}"
>
> to see if $ABC is unset.
>
> Thanks
>
> Phillip
>> +	then
>> +		eval "$1=\$2"

This one may want to quote the right hand side to be more widely portable, i.e., eval "$1=\"\$2\"" or something along that line. POSIX Bourne shell does not require the right hand side

    VARIABLE=$VAR

to be quoted, but CodingGuidelines has observed some buggy shells. It may be better to be extra clear than sorry.

Previous: Phillip WoodNext: Patrick Steinhardt
Message 11 of 32 in “ci: consolidate test variables”
  1. 0/8 ci: consolidate test variablesPatrick Steinhardt, Oct 27, 2026
  2. 1/8 ci: consolidate setup of test environmentPatrick Steinhardt, Oct 27, 2026
  3. 2/8 ci/lib: always set GIT_TEST_USE_SET_E on Linux jobsPatrick Steinhardt, Oct 27, 2026
  4. 3/8 ci/lib: deduplicate test variables by pattern matchingPatrick Steinhardt, Oct 27, 2026
  5. 4/8 ci/lib: merge switches for specific job namesPatrick Steinhardt, Oct 27, 2026
  6. 5/8 t: honor default ref storage formatPatrick Steinhardt, Oct 27, 2026
  7. 6/8 ci/lib: add another NO_RUST build using glibcPatrick Steinhardt, Oct 27, 2026
  8. 7/8 ci: don't override initial branch name in testbed jobPatrick Steinhardt, Oct 27, 2026
  9. 8/8 t/test-lib: make feature-testbed job more accessiblePatrick Steinhardt, Oct 27, 2026
  10. Phillip WoodOct 27, 2026
  11. Junio C HamanoOct 27, 2026
  12. Patrick SteinhardtOct 28, 2026
  13. Jeff KingOct 27, 2026
  14. Junio C HamanoOct 27, 2026
  15. Patrick SteinhardtOct 28, 2026
  16. Phillip WoodOct 28, 2026
  17. Patrick SteinhardtNov 2, 2026
  18. Phillip WoodOct 27, 2026
  19. Junio C HamanoOct 27, 2026
  20. Jeff KingOct 27, 2026
  21. Toon ClaesOct 28, 2026
  22. 0/7 ci: consolidate test variablesPatrick Steinhardt, Nov 2, 2026
  23. 1/7 ci: consolidate setup of test environmentPatrick Steinhardt, Nov 2, 2026
  24. 2/7 ci/lib: always set GIT_TEST_USE_SET_E on Linux jobsPatrick Steinhardt, Nov 2, 2026
  25. 3/7 ci/lib: deduplicate test variables by pattern matchingPatrick Steinhardt, Nov 2, 2026
  26. 4/7 ci/lib: merge switches for specific job namesPatrick Steinhardt, Nov 2, 2026
  27. 5/7 t: honor default ref storage formatPatrick Steinhardt, Nov 2, 2026
  28. 6/7 ci/lib: add another NO_RUST build using glibcPatrick Steinhardt, Nov 2, 2026
  29. 7/7 ci: don't override initial branch name in testbed jobPatrick Steinhardt, Nov 2, 2026
  30. Phillip WoodNov 2, 2026
  31. Jeff KingNov 4, 2026
  32. Junio C HamanoNov 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.