Re: [PATCH 0/8] ci: consolidate test variables
- From
Toon Claes <toon@iotcl.com>
- Date
- Oct 28, 2026, 14:40 UTC
- Message-ID
- <87mrrxzy4p.fsf@dev.null.iotcl.com.invalid>
- In-Reply-To
- <20261027212431.GB774120@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> On Tue, Oct 27, 2026 at 09:18:20AM +0100, Patrick Steinhardt wrote: > >> this patch series consolidates our test variables as a follow up on the >> discussions in [1]. > > Thanks for following up. 1-7 seem obviously good to me.
Yes, 1-7 look good and are pretty much noncontroversial.
> I'm lukewarm on the final patch (and left a comment there), but if you > really love it, I can live with it. :)
I understand the stance of both of you. To be honest, I don't really have an opinion. The cleanest fix probably would be to split the build flags from test flags, because it's a mix now and Peff prefers to have them all fixed, while Patrick likes to change them run-by-run. Although, that would probably lead this patch series beyond their intentions.
-- Laters, Toon