git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 8/8] t/test-lib: make feature-testbed job more accessible

From
Jeff King <peff@peff.net>
Date
Oct 27, 2026, 21:23 UTC
Message-ID
<20261027212349.GA774120@coredump.intra.peff.net>
In-Reply-To
<20261027-b4-pks-ci-test-vars-consolidation-v1-8-f28edf79bd6c@pks.im>
On Tue, Oct 27, 2026 at 09:18:28AM +0100, Patrick Steinhardt wrote:
> Due to the job being special it has a higher potential of failing even
> though a local test run succeeds. But running these tests locally with
> the same environment is somewhat painful, as the developer has to
> manually set all of these environment variables.

OK. I've usually just cut-and-paste them, as my first step is figuring out which is the culprit anyway. My biggest question was: what if the culprit is a build flag, and indeed, we leave the one build flag here:

Show 14 quoted lines
>  linux-feature-testbed)
>  	export OPENSSL_SHA1_UNSAFE=YesPlease
> -	export GIT_TEST_SPLIT_INDEX=yes
> -	export GIT_TEST_FULL_IN_PACK_ARRAY=true
> -	export GIT_TEST_OE_SIZE=10
> -	export GIT_TEST_OE_DELTA_SIZE=5
> -	export GIT_TEST_COMMIT_GRAPH=1
> -	export GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS=1
> -	export GIT_TEST_MULTI_PACK_INDEX=1
> -	export GIT_TEST_MULTI_PACK_INDEX_WRITE_INCREMENTAL=1
> -	export GIT_TEST_NO_WRITE_REV_INDEX=1
> -	export GIT_TEST_CHECKOUT_WORKERS=2
> -	export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1
> +	GIT_TEST_OPTS="$GIT_TEST_OPTS --feature-testbed"

which makes this feature only half-work (well, 11/12 if we want to be pedantic).

IMHO this whole thing isn't really worth the complexity, but if we are going to do it, should it be "make FEATURE_TESTBED=1", and then that enables the right build knobs, and test-lib.sh respects that variable coming from BUILD-OPTIONS rather than the command line?

-Peff
Previous: Patrick SteinhardtNext: Junio C Hamano
Message 13 of 32 in “ci: consolidate test variables”
  1. 0/8 ci: consolidate test variablesPatrick Steinhardt, Oct 27, 2026
  2. 1/8 ci: consolidate setup of test environmentPatrick Steinhardt, Oct 27, 2026
  3. 2/8 ci/lib: always set GIT_TEST_USE_SET_E on Linux jobsPatrick Steinhardt, Oct 27, 2026
  4. 3/8 ci/lib: deduplicate test variables by pattern matchingPatrick Steinhardt, Oct 27, 2026
  5. 4/8 ci/lib: merge switches for specific job namesPatrick Steinhardt, Oct 27, 2026
  6. 5/8 t: honor default ref storage formatPatrick Steinhardt, Oct 27, 2026
  7. 6/8 ci/lib: add another NO_RUST build using glibcPatrick Steinhardt, Oct 27, 2026
  8. 7/8 ci: don't override initial branch name in testbed jobPatrick Steinhardt, Oct 27, 2026
  9. 8/8 t/test-lib: make feature-testbed job more accessiblePatrick Steinhardt, Oct 27, 2026
  10. Phillip WoodOct 27, 2026
  11. Junio C HamanoOct 27, 2026
  12. Patrick SteinhardtOct 28, 2026
  13. Jeff KingOct 27, 2026
  14. Junio C HamanoOct 27, 2026
  15. Patrick SteinhardtOct 28, 2026
  16. Phillip WoodOct 28, 2026
  17. Patrick SteinhardtNov 2, 2026
  18. Phillip WoodOct 27, 2026
  19. Junio C HamanoOct 27, 2026
  20. Jeff KingOct 27, 2026
  21. Toon ClaesOct 28, 2026
  22. 0/7 ci: consolidate test variablesPatrick Steinhardt, Nov 2, 2026
  23. 1/7 ci: consolidate setup of test environmentPatrick Steinhardt, Nov 2, 2026
  24. 2/7 ci/lib: always set GIT_TEST_USE_SET_E on Linux jobsPatrick Steinhardt, Nov 2, 2026
  25. 3/7 ci/lib: deduplicate test variables by pattern matchingPatrick Steinhardt, Nov 2, 2026
  26. 4/7 ci/lib: merge switches for specific job namesPatrick Steinhardt, Nov 2, 2026
  27. 5/7 t: honor default ref storage formatPatrick Steinhardt, Nov 2, 2026
  28. 6/7 ci/lib: add another NO_RUST build using glibcPatrick Steinhardt, Nov 2, 2026
  29. 7/7 ci: don't override initial branch name in testbed jobPatrick Steinhardt, Nov 2, 2026
  30. Phillip WoodNov 2, 2026
  31. Jeff KingNov 4, 2026
  32. Junio C HamanoNov 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.